Re: [Nouveau] [PATCH -next] drm/ttm: Remove set but not used variable 'mem'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 10 Jan 2020 at 17:32, YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>
> drivers/gpu/drm/nouveau/nouveau_ttm.c: In function nouveau_vram_manager_new:
> drivers/gpu/drm/nouveau/nouveau_ttm.c:66:22: warning: variable mem set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/nouveau/nouveau_ttm.c: In function nouveau_gart_manager_new:
> drivers/gpu/drm/nouveau/nouveau_ttm.c:106:22: warning: variable mem set but not used [-Wunused-but-set-variable]
>
> They are not used any more, so remove it.
Thanks!

>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/nouveau/nouveau_ttm.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c
> index 77a0c6a..7ca0a24 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c
> @@ -63,14 +63,12 @@ nouveau_vram_manager_new(struct ttm_mem_type_manager *man,
>  {
>         struct nouveau_bo *nvbo = nouveau_bo(bo);
>         struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
> -       struct nouveau_mem *mem;
>         int ret;
>
>         if (drm->client.device.info.ram_size == 0)
>                 return -ENOMEM;
>
>         ret = nouveau_mem_new(&drm->master, nvbo->kind, nvbo->comp, reg);
> -       mem = nouveau_mem(reg);
>         if (ret)
>                 return ret;
>
> @@ -103,11 +101,9 @@ nouveau_gart_manager_new(struct ttm_mem_type_manager *man,
>  {
>         struct nouveau_bo *nvbo = nouveau_bo(bo);
>         struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
> -       struct nouveau_mem *mem;
>         int ret;
>
>         ret = nouveau_mem_new(&drm->master, nvbo->kind, nvbo->comp, reg);
> -       mem = nouveau_mem(reg);
>         if (ret)
>                 return ret;
>
> --
> 2.7.4
>
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/nouveau
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux