Hi Jitao. On Sat, Oct 12, 2019 at 11:07:12AM +0800, Jitao Shi wrote: > Changes since v6: > - fix boe_panel_init err uninit. > - adjust the delay of backlight on. > > Changes since v5: > - covert the documents to yaml > - fine tune boe, tv101wum-n53 panel video timine I finally found some time to looks at this. The bindings does unfortunately not pass a dt_binding_check I had to locally do the following to make on of the bindings pass: diff --git a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml b/Documentation/devicetree/bindings/display/panel/auo ,b101uan08.3.yaml index c0939f8c7274..cafa870120fb 100644 --- a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml +++ b/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml @@ -11,6 +11,9 @@ maintainers: - Sam Ravnborg <sam@xxxxxxxxxxxx> - Rob Herring <robh+dt@xxxxxxxxxx> +allOf: + - $ref: panel-common.yaml# + properties: compatible: const: auo,b101uan08.3 @@ -33,6 +36,8 @@ properties: backlight: description: phandle of the backlight device attached to the panel + port: true + required: - compatible - reg @@ -46,7 +51,9 @@ additionalProperties: false examples: - | - &dsi { + dsi { + #address-cells = <1>; + #size-cells = <0>; panel@0 { compatible = "auo,b101uan08.3"; reg = <0>; I will follow-up with review feedback on the drivers later as time permits. Sam _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel