* Matthijs van Duin <matthijsvanduin@xxxxxxxxx> [200104 05:10]: > On Sat, Dec 21, 2019 at 08:41:41AM -0800, Tony Lindgren wrote: > > Also, I'm wondering if this change makes sense alone without the pinning > > changes for a fix, or if also the pinning changes are needed. > > Both pinning and page-alignment are done just to support the direct > userspace mapping. By themselves they mostly just waste tiler memory > but otherwise don't really have much impact. OK thanks, so no specific fix, that's the part I was wondering about :) > It's not really clear to me why you have such interest in this specific > patch. Does my patch series fix the tearing issue you've described? If > so maybe without my patches tiled memory is just so slow that the frame > is being submitted too late, which perhaps causes an async page flip > (does it? I'm not sure) thus resulting in tearing? Just changing the alingment fixes the issue. Looks like the minimum alignment we currently allow is 128, I think 512 was the minimum that worked for me, so maybe the right fix would be to just change the minimum to 512 with no specific need to use 4096 for now. I did not see any issue with frame updates being too slow, I just picked that alignment change manually without trying the rest of your series. Regards, Tony _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
