Hi Jani. On Mon, Dec 23, 2019 at 01:29:19PM +0200, Jani Nikula wrote: > On Sat, 21 Dec 2019, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > There are a lot of cases where we have a device * but no drm_device *. > > Add drm_dev_* variants of the logging functions to cover these cases. > > So I know there are some valid cases where we only have struct device *, > and instead of passing struct drm_device * will need the distinction > between multiple struct device *. > > Not all current uses of DRM_DEV_* meet that criteria, however. I think > I'd like to have those converted over to the drm_device based logging > first, and then see what's left. Because I fear adding these will just > lead to mass conversion from DRM_DEV_* to drm_dev_*, and the ball gets > dropped there. Hmm... $ git grep -E '(DRM_DEV_ERROR|DRM_DEV_INFO|DRM_DEV_WARN|DRM_DEV_DEBUG)' 953 There are 4 hits in drm/* - the rest is in drivers (no suprise). $ git grep -E '(DRM_ERROR|DRM_INFO|DRM_WARN|DRM_DEBUG)' | wc -l 8380 There are 626 hits in drm/* - the rest in drivers. So moving over all DRM_DEV looks doable with a lot of effort. It touches all drivers. But the non-DEV variants - thats just too much. This is a lot of effort required before we can offer new drivers a simple a logical logging solution. On top of this - there is today no gain using drm_device * versus device *. The output is exactly the same. We should discuss what is required before we can offer the full solution for new drivers. And how much the existing usage should hold this back. Sam _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
