On Sat, 21 Dec 2019, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> Hi Joe.
>
>> > +#define __drm_dev_cat_printk(dev, cat, type, fmt, ...) \
>> > +({ \
>> > + if (drm_debug_enabled(cat)) \
>> > + dev_dbg##type((dev), "[drm] " fmt, ##__VA_ARGS__); \
>>
>> trivia: The parentheses around dev aren't necessary.
>>
>> > +})
>> > +
>> > +#define drm_dev_info(dev, fmt, ...) \
>> > + __drm_dev_printk((dev), info,, fmt, ##__VA_ARGS__)
>>
>> etc...
>
> I was not really sure so I just added them.
> Will remove in v2 in all relevent patches - thanks!
FWIW, they are necessary in the drm_device variants due to the macros
doing the dereferencing.
BR,
Jani.
>
> Sam
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
