On 2019-12-18 11:13 a.m., Manna, Animesh wrote: > > On 18-12-2019 21:12, Harry Wentland wrote: >> On 2019-12-18 10:13 a.m., Animesh Manna wrote: >>> [Why]: >>> Aligh with DP spec wanted to follow same naming convention. >>> >>> [How]: >>> Changed the macro name of the dpcd address used for getting requested >>> test-pattern. >>> >> Please roll this into your patch that renames the definition. All >> patches should compile on their own. > > > Thanks Harry for review, wanted to follow similar commit-description > format followed in amd-driver compare to i915 and created a separate > patch. Maybe is it good idea to change the patch sequence and make it as > first patch. > Thanks for looking to follow the commit style from the rest of the amd driver but in this case we need to combine them or you'll be left with one patch in the sequence that won't build on its own. Harry > Regards, > Animesh > >> >> Thanks, >> Harry >> >>> Cc: Harry Wentland <harry.wentland@xxxxxxx> >>> Cc: Alex Deucher <alexander.deucher@xxxxxxx> >>> Signed-off-by: Animesh Manna <animesh.manna@xxxxxxxxx> >>> --- >>> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >>> b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >>> index 42aa889fd0f5..1a6109be2fce 100644 >>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c >>> @@ -2491,7 +2491,7 @@ static void >>> dp_test_send_phy_test_pattern(struct dc_link *link) >>> /* get phy test pattern and pattern parameters from DP receiver */ >>> core_link_read_dpcd( >>> link, >>> - DP_TEST_PHY_PATTERN, >>> + DP_PHY_TEST_PATTERN, >>> &dpcd_test_pattern.raw, >>> sizeof(dpcd_test_pattern)); >>> core_link_read_dpcd( >>> _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
