Re: [PATCH 0/9] *** virtgpu cleanups ***

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 17, 2019 at 04:59:20PM -0800, Gurchetan Singh wrote:
> With so many new features on the horizon, perhaps it's
> time to do a little "winter cleaning" beforehand. Enjoy!
> 
>   drm/virtio: static-ify virtio_gpu_framebuffer_init

Doesn't apply cleanly.  What kernel is this against?

>   drm/virtio: remove virtgpu_gem_prime_import_sg_table

I'd prefer to keep that.  Once we have blob resource support we can
actually handle dma-buf imports.

>   drm/virtio: split out vq functions from virtgpu_drv.h
>   drm/virtio: split out gem functions from virtgpu_drv.h

Hmm, I'd prefer to have everything in one header, and the file isn't
that big that it is unmanageable...

The other patches look fine to me.  Didn't test whenever they apply
though, tried only the whole series which stopped at patch #2).

cheers,
  Gerd

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux