Hi Stephan, I fixed up the patch according to your comments, this remains: On Mon, Dec 16, 2019 at 6:55 PM Stephan Gerhold <stephan@xxxxxxxxxxx> wrote: > In general I was wondering if we could benefit from using something like > the regmap_update_bits() helper to avoid having to write this manually > all the time. However, this does not have anything to do with this patch > - just an idea that could be discussed separately. Yeah I can take a stab at simply converting the whole thing to regmap-mmio, I thinkt it'd be pretty quick and we can see how it looks. Maybe easier to debug as well. Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel