On Mon, Dec 16, 2019 at 02:39:53PM +0100, Paul Cercueil wrote: > Hi Ville, > > > Le lun., déc. 16, 2019 at 15:15, Ville Syrjälä > <ville.syrjala@xxxxxxxxxxxxxxx> a écrit : > > On Sat, Dec 14, 2019 at 11:54:18AM +0100, Sam Ravnborg wrote: > >> Hi Paul. > >> > >> On Tue, Dec 10, 2019 at 03:41:37PM +0100, Paul Cercueil wrote: > >> > Add a compatible string for the LCD controller found in the > >> JZ4770 SoC. > >> > > >> > v2: No change > >> > > >> > Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx> > >> > Acked-by: Rob Herring <robh@xxxxxxxxxx> > >> > >> Whole series looks good. > >> Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > > > Paul, looks like you forgot to git commit --amend after adding the > > tags. > > Now the commit messages have and extra "# *** extracted tags ***" in > > them. > > Sorry, I'm still relatively new to this :( > > I thought they were going to be automatically removed since they are > comments. They will be of you commit --amend. But not without that. People tend to typo these things quite often so I made dim extract-tags rather liberal in what it accepts. And sometimes that means it'll pull in all kinds of crap when people put a ':' in the wrong place. And that's the reason I added the extra marker so it's trivial to see what got pulled in by dim and what was there already. But it does mean you always have to do the --amend to get rid of the markers. I guess there are at least two options to improve the situation: a) make dim extract-tags more strict and risk missing typoed tags b) make dim push check that there marker has been removed from the commit msg -- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
