Re: [PATCH] drm/panfrost: Prefix interrupt handlers' names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> (Feedback for kernel patches on the same day, am I dreaming??)

That's panfrost!

> > Agreed, while the current implementation may be confusing it is at least 
> > self-consistent. TBH it would probably be sufficient to save the bother 
> > of allocating strings and just settle on "panfrost-{gpu,job,mmu}", since 
> > upstream users are unlikely to ever come across a system with more than 
> > one Mali in it ;)
> > 
> > And FWIW note that "GPU" really is the specific hardware name of that 
> > IRQ output; it's not just a generic fill-in for "the one that isn't the 
> > Job or MMU IRQ".
> > 
> 
> Yeah, that makese sense. So how about we go for "panfrost-{job,mmu}"
> and leave the "gpu" one?
> 
> Or "panfrost-{gpu,job,mmu}" for consistency?

I would prefer "panfrost-{gpu,job,mmu}" for consistency, I think.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux