On Mon, 9 Dec 2019 at 09:47, Jerry Han <jerry.han.hq@xxxxxxxxx> wrote: > > Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI > panel. > > V9: > - Adjust init code, make the format more concise > - kill off default_off_cmds (Emil) > - use mipi_dsi_dcs_set_display_{on,off} in their enable/disable > callbacks. (Emil) > - Adjusting the delay function (Emil) > > V8: > - modify PARENTHESIS_ALIGNMENT format (Sam) > - use gpios are required API replace optional gpio API (Emil) > > V7: > - Modify communication address > > V6: > - Add the information of the reviewer > - Remove unnecessary delays, The udelay_range code gracefully returns > without hitting the scheduler on a delay of 0. (Derek) > - Merge the same data structures, like display_mode and off_cmds (Derek) > - Optimize the processing of results returned by > devm_gpiod_get_optional (Derek) > > V5: > - Add the information of the reviewer (Sam) > - Delete unnecessary header files #include <linux/fb.h> (Sam) > - The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam) > - ADD static, set_gpios function is not used outside this module (Sam) > > V4: > - Frefix all function maes with boe_ (Sam) > - Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam) > - Sort include lines alphabetically (Sam) > - Fixed entries in the makefile must be sorted alphabetically (Sam) > - Add send_mipi_cmds function to avoid duplicating the code (Sam) > - Add the necessary delay(reset_delay_t5) between reset and sending > the initialization command (Rock wang) > > V3: > - Remove unnecessary delays in sending initialization commands (Jitao Shi) > > V2: > - Use SPDX identifier (Sam) > - Use necessary header files replace drmP.h (Sam) > - Delete unnecessary header files #include <linux/err.h> (Sam) > - Specifies a GPIOs array to control the reset timing, > instead of reading "dsi-reset-sequence" data from DTS (Sam) > - Delete backlight_disable() function when already disabled (Sam) > - Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam) > - Move the necessary data in the DTS to the current file, > like porch, display_mode and Init code etc. (Sam) > - Add compatible device "boe,himax8279d10p" (Sam) > > V1: > - Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI > panel. > > Signed-off-by: Jerry Han <jerry.han.hq@xxxxxxxxx> > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Reviewed-by: Derek Basehore <dbasehore@xxxxxxxxxxxx> > Reviewed-by: Emil Velikov <emil.l.velikov@xxxxxxxxx> v9 looks much better thanks. My R-B now stands: Reviewed-by: Emil Velikov <emil.l.velikov@xxxxxxxxx> Sam, care you give this a quick look and merge if you're happy with latest revision? v9 have changed quite a bit since you've reviewed it - same functionality with 10% less code ;-) -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel