On Thu, Nov 28, 2019 at 12:39:30PM +0100, Gerd Hoffmann wrote: > On Wed, Nov 27, 2019 at 10:25:22AM +0100, Gerd Hoffmann wrote: > > The fake offset is going to stay, so change the calling convention for > > drm_gem_object_funcs.mmap to include the fake offset. Update all users > > accordingly. > > > > Note that this reverts 83b8a6f242ea ("drm/gem: Fix mmap fake offset > > handling for drm_gem_object_funcs.mmap") and on top then adds the fake > > offset to drm_gem_prime_mmap to make sure all paths leading to > > obj->funcs->mmap are consistent. > > > > v3: move fake-offset tweak in drm_gem_prime_mmap() so we have this code > > only once in the function (Rob Herring). > > Now this series fails in Intel CI. Can't see why though. The > difference between v2 and v3 is just the place where vma->vm_pgoff gets > updated, and no code between the v2 and v3 location touches vma ... Looks like unrelated flukes, this happens occasionally. If you're paranoid hit the retest button on patchwork to double-check. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel