On Thu, 5 Dec 2019 at 18:28, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > >> +/* Interrupt fields */ > >> +#define MGA_VLINEPEN (0x01 << 5) > >> +#define MGA_VLINECLR (0x01 << 5) > >> +#define MGA_VLINEIEN (0x01 << 5) > > Use BIT(5)? > > The bitfield name could be more readable if they included the register > > name. > > Example: > > #define MGA_STATUS_VLINEPEN BIT(5) > > #define MGA_ICLEAR_VLINECLR BIT(5) > > #define MGA_IEN_VLINEIEN BIT(5) > > Oh, good point. I wasn't aware of this macro. > While at it, please keep bitfields close to the respective registers. Don't know much about the driver to review this, for 1&2 Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> I'll look at 4/4 first thing tomorrow. Thanks Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
