Hi,
On Fri, Nov 29, 2019 at 12:35:05PM +0530, Harigovindan P wrote:
> Changes in v1:
> -Modify commit text to indicate DSI version and SOC detail(Jeffrey Hugo).
> -Splitting visionox panel driver code out into a
> different patch(set), since panel drivers are merged into
> drm-next via a different tree(Rob Clark).
The change log shouldn't be part of the commit message, please place it
after the '---' separator.
I think at least a one line commit message besides the subject is
mandatory, so if you move the change log down you'll have to add
some short summary.
> Signed-off-by: Harigovindan P <harigovi@xxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/dsi/dsi_cfg.c | 21 +++++++++++++++++++++
> drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 +
> 2 files changed, 22 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> index b7b7c1a..7b967dd 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> @@ -133,6 +133,10 @@ static const char * const dsi_sdm845_bus_clk_names[] = {
> "iface", "bus",
> };
>
> +static const char * const dsi_sc7180_bus_clk_names[] = {
> + "iface", "bus",
> +};
> +
> static const struct msm_dsi_config sdm845_dsi_cfg = {
> .io_offset = DSI_6G_REG_SHIFT,
> .reg_cfg = {
> @@ -147,6 +151,20 @@ static const struct msm_dsi_config sdm845_dsi_cfg = {
> .num_dsi = 2,
> };
>
> +static const struct msm_dsi_config sc7180_dsi_cfg = {
> + .io_offset = DSI_6G_REG_SHIFT,
> + .reg_cfg = {
> + .num = 1,
> + .regs = {
> + {"vdda", 21800, 4 }, /* 1.2 V */
> + },
> + },
> + .bus_clk_names = dsi_sc7180_bus_clk_names,
> + .num_bus_clks = ARRAY_SIZE(dsi_sc7180_bus_clk_names),
> + .io_start = { 0xae94000 },
> + .num_dsi = 1,
> +};
> +
> const static struct msm_dsi_host_cfg_ops msm_dsi_v2_host_ops = {
> .link_clk_enable = dsi_link_clk_enable_v2,
> .link_clk_disable = dsi_link_clk_disable_v2,
> @@ -201,6 +219,9 @@ static const struct msm_dsi_cfg_handler dsi_cfg_handlers[] = {
> &msm8998_dsi_cfg, &msm_dsi_6g_v2_host_ops},
> {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_2_1,
> &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops},
> + {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_1,
> + &sc7180_dsi_cfg, &msm_dsi_6g_v2_host_ops},
> +
> };
>
> const struct msm_dsi_cfg_handler *msm_dsi_cfg_get(u32 major, u32 minor)
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> index e2b7a7d..9919536 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h
> @@ -19,6 +19,7 @@
> #define MSM_DSI_6G_VER_MINOR_V1_4_1 0x10040001
> #define MSM_DSI_6G_VER_MINOR_V2_2_0 0x20000000
> #define MSM_DSI_6G_VER_MINOR_V2_2_1 0x20020001
> +#define MSM_DSI_6G_VER_MINOR_V2_4_1 0x20040001
>
> #define MSM_DSI_V2_VER_MINOR_8064 0x0
>
> --
> 2.7.4
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
