On Tue, Nov 26, 2019 at 11:46:54AM +0000, Liviu Dudau wrote:
> On Tue, Nov 26, 2019 at 10:14:14AM +0100, Daniel Vetter wrote:
> > 0 means 1 as the default, but it's mighty confusing if the block size
> > for the first plane is spelled out explicitly, but not for the 2nd
> > plane.
> >
> > No cc: stable because this is just confusion, but 0 functional issue.
>
> Agree!
>
> >
> > Fixes: 7ba0fee247ee ("drm/fourcc: Add AFBC yuv fourccs for Mali")
> > Cc: Brian Starkey <brian.starkey@xxxxxxx>
> > Cc: Ayan Kumar Halder <ayan.halder@xxxxxxx>
> > Cc: Liviu Dudau <liviu.dudau@xxxxxxx>
>
> Acked-by: Liviu Dudau <liviu.dudau@xxxxxxx>
Both patches applied, thanks for taking a look.
-Daniel
>
> Best regards,
>
> > Cc: Alyssa Rosenzweig <alyssa@xxxxxxxxxxxxx>
> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> > Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/drm_fourcc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
> > index fe79ce857c8a..b234bfaeda06 100644
> > --- a/drivers/gpu/drm/drm_fourcc.c
> > +++ b/drivers/gpu/drm/drm_fourcc.c
> > @@ -263,7 +263,7 @@ const struct drm_format_info *__drm_format_info(u32 format)
> > .hsub = 2, .vsub = 2, .is_yuv = true},
> > { .format = DRM_FORMAT_P210, .depth = 0,
> > .num_planes = 2, .char_per_block = { 2, 4, 0 },
> > - .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 }, .hsub = 2,
> > + .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 }, .hsub = 2,
> > .vsub = 1, .is_yuv = true },
> > { .format = DRM_FORMAT_VUY101010, .depth = 0,
> > .num_planes = 1, .cpp = { 0, 0, 0 }, .hsub = 1, .vsub = 1,
> > --
> > 2.24.0
> >
>
> --
> ====================
> | I would like to |
> | fix the world, |
> | but they're not |
> | giving me the |
> \ source code! /
> ---------------
> ¯\_(ツ)_/¯
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
