Hi Geert, On Thu, Nov 28, 2019 at 08:56:14AM +0100, Geert Uytterhoeven wrote: > On Wed, Nov 13, 2019 at 11:04 AM Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote: > > Add a driver for the R-Car Display Unit Color Correction Module. > > In most of Gen3 SoCs, each DU output channel is provided with a CMM unit > > to perform image enhancement and color correction. > > > > Add support for CMM through a driver that supports configuration of > > the 1-dimensional LUT table. More advanced CMM features will be > > implemented on top of this initial one. > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > > > --- a/drivers/gpu/drm/rcar-du/Kconfig > > +++ b/drivers/gpu/drm/rcar-du/Kconfig > > @@ -5,6 +5,7 @@ config DRM_RCAR_DU > > depends on ARM || ARM64 > > depends on ARCH_RENESAS || COMPILE_TEST > > imply DRM_RCAR_LVDS > > + imply DRM_RCAR_CMM > > select DRM_KMS_HELPER > > select DRM_KMS_CMA_HELPER > > select DRM_GEM_CMA_HELPER > > @@ -13,6 +14,13 @@ config DRM_RCAR_DU > > Choose this option if you have an R-Car chipset. > > If M is selected the module will be called rcar-du-drm. > > > > +config DRM_RCAR_CMM > > + tristate "R-Car DU Color Management Module (CMM) Support" > > + depends on DRM && OF > > + depends on DRM_RCAR_DU > > DRM_RCAR_DU already depends on DRM && OF, so the line above > can be removed. I've sent a pull request already. Can we address this on top ? Or is it worth a separate patch, should we wait until we have to touch this and then fix it in a "while at it" fashion ? -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
