On Mon, Nov 25, 2019 at 10:00 AM YueHaibing <yuehaibing@xxxxxxxxxx> wrote: > > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vegam_smumgr.c: > In function vegam_populate_clock_stretcher_data_table: > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vegam_smumgr.c:1489:29: > warning: variable stretch_amount2 set but not used [-Wunused-but-set-variable] > > It is never used, so can be removed. > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> Applied. thanks! Alex > --- > drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c > index 50896e9..b0e0d67 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c > @@ -1486,7 +1486,7 @@ static int vegam_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr) > struct vegam_smumgr *smu_data = > (struct vegam_smumgr *)(hwmgr->smu_backend); > > - uint8_t i, stretch_amount, stretch_amount2, volt_offset = 0; > + uint8_t i, stretch_amount, volt_offset = 0; > struct phm_ppt_v1_information *table_info = > (struct phm_ppt_v1_information *)(hwmgr->pptable); > struct phm_ppt_v1_clock_voltage_dependency_table *sclk_table = > @@ -1525,11 +1525,9 @@ static int vegam_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr) > (table_info->cac_dtp_table->ucCKS_LDO_REFSEL != 0) ? > table_info->cac_dtp_table->ucCKS_LDO_REFSEL : 5; > /* Populate CKS Lookup Table */ > - if (stretch_amount == 1 || stretch_amount == 2 || stretch_amount == 5) > - stretch_amount2 = 0; > - else if (stretch_amount == 3 || stretch_amount == 4) > - stretch_amount2 = 1; > - else { > + if (!(stretch_amount == 1 || stretch_amount == 2 || > + stretch_amount == 5 || stretch_amount == 3 || > + stretch_amount == 4)) { > phm_cap_unset(hwmgr->platform_descriptor.platformCaps, > PHM_PlatformCaps_ClockStretcher); > PP_ASSERT_WITH_CODE(false, > -- > 2.7.4 > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel