Re: [PATCH v7 01/24] mm/gup: pass flags arg to __gup_device_* functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v7 01/24] mm/gup: pass flags arg to __gup_device_* functions
From: John Hubbard <jhubbard@xxxxxxxxxx>
Date: Thu, 21 Nov 2019 00:25:08 -0800
Cc: Michal Hocko <mhocko@xxxxxxxx>, Jan Kara <jack@xxxxxxx>, kvm@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, David Airlie <airlied@xxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, Paul Mackerras <paulus@xxxxxxxxx>, linux-kselftest@xxxxxxxxxxxxxxx, Ira Weiny <ira.weiny@xxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, linux-rdma@xxxxxxxxxxxxxxx, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Björn Töpel <bjorn.topel@xxxxxxxxx>, linux-media@xxxxxxxxxxxxxxx, Shuah Khan <shuah@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, Jérôme Glisse <jglisse@xxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, bpf@xxxxxxxxxxxxxxx, Magnus Karlsson <magnus.karlsson@xxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Alex Williamson <alex.williamson@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, "David S . Miller" <davem@xxxxxxxxxxxxx>, "Kirill A . Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, Mike Kravetz <mike.kravetz@xxxxxxxxxx>
In-reply-to: <20191121080644.GA30991@infradead.org>
References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-2-jhubbard@nvidia.com> <20191121080644.GA30991@infradead.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 11/21/19 12:06 AM, Christoph Hellwig wrote:

On Wed, Nov 20, 2019 at 11:13:31PM -0800, John Hubbard wrote:

A subsequent patch requires access to gup flags, so
pass the flags argument through to the __gup_device_*
functions.


Looks fine, but why not fold this into the patch using the flags.


Yes, I'll do that.


Also you can use up your full 73 chars per line in the commit log.


OK.

thanks,
--
John Hubbard
NVIDIA
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

References:
- [PATCH v7 00/24] mm/gup: track dma-pinned pages: FOLL_PIN
  - From: John Hubbard
- [PATCH v7 01/24] mm/gup: pass flags arg to __gup_device_* functions
  - From: John Hubbard

Prev by Date: Re: [RESEND PATCH v2] drm: Add getfb2 ioctl
Next by Date: Re: [PATCH v7 02/24] mm/gup: factor out duplicate code from four routines
Previous by thread: [PATCH v7 01/24] mm/gup: pass flags arg to __gup_device_* functions
Next by thread: [PATCH v7 14/24] drm/via: set FOLL_PIN via pin_user_pages_fast()
Index(es):
- Date
- Thread

[Index of Archives] [Linux DRI Users] [Linux Intel Graphics] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [XFree86] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [XFree86]