Re: [PATCH 0/4] drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code

[Tomi Valkeinen <tomi.valkeinen@xxxxxx>]

Hi zhengbin,

On 18/11/2019 14:07, zhengbin wrote:
> zhengbin (4):
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
>      hdmi_audio_register
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
>      hdmi4_core_init
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in
>      hdmi5_core_init
>    drm/omap: dss: Use PTR_ERR_OR_ZERO() to simplify code in hdmi_phy_init
>
>   drivers/gpu/drm/omapdrm/dss/hdmi4.c      | 5 +----
>   drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 5 +----
>   drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 5 +----
>   drivers/gpu/drm/omapdrm/dss/hdmi_phy.c   | 5 +----
>   4 files changed, 4 insertions(+), 16 deletions(-)

Thanks, but I don't like PTR_ERR_OR_ZERO, I think it makes the code more 
difficult to read and manage.

 Tomi

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel