Re: [PATCH] drm/amdkfd: remove set but not used variable 'top_dev'

[Felix Kuehling <felix.kuehling@xxxxxxx>]

On 2019-11-13 10:20 p.m., zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c: In function kfd_iommu_device_init:
> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c:65:30: warning: variable top_dev set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Fixes: 1ae99eab34f9 ("drm/amdkfd: Initialize HSA_CAP_ATS_PRESENT capability in topology codes")
> Signed-off-by: zhengbin <zhengbin13@xxxxxxxxxx>

The patch is

Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>

I'm applying it to amd-staging-drm-next.

Thanks,
  Felix


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_iommu.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
> index 193e283..8d87151 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_iommu.c
> @@ -62,9 +62,6 @@ int kfd_iommu_device_init(struct kfd_dev *kfd)
>   	struct amd_iommu_device_info iommu_info;
>   	unsigned int pasid_limit;
>   	int err;
> -	struct kfd_topology_device *top_dev;
> -
> -	top_dev = kfd_topology_device_by_id(kfd->id);
>
>   	if (!kfd->device_info->needs_iommu_device)
>   		return 0;
> --
> 2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel