On Wed, 6 Nov 2019 at 16:30, Adrian Ratiu <adrian.ratiu@xxxxxxxxxxxxx> wrote: > > Convert the common bridge code and the two rockchip & stm drivers > which currently use it to the regmap API in anticipation for further > changes to make it more generic and add older DSI host controller > support as found on i.mx6 based devices. > > The regmap becomes an internal state of the bridge. No functional > changes other than requiring the platform drivers to use the > pre-configured regmap supplied by the bridge after its probe() call > instead of ioremp'ing the registers themselves. > > In subsequent commits the bridge will become able to detect the > DSI host core version and init the regmap with different register > layouts. The platform drivers will continue to use the regmap without > modifications or worrying about the specific layout in use (in other > words the layout is abstracted away via the regmap). > > Suggested-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > Reviewed-by: Emil Velikov <emil.l.velikov@xxxxxxxxx> I should have been clearer earlier - I didn't quite review the patch. Is is now though. Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> Admittedly a couple of nitpicks (DRIVER_NAME, zero initialize of val) could have been left out. It's not a big deal, there's no need to polish those. -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
