Re: [PATCH] drm/vmwgfx: remove set but not used variable 'srf'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ping

On 2019/10/31 21:41, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/vmwgfx/vmwgfx_surface.c: In function vmw_hw_surface_destroy:
> drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:335:22: warning: variable srf set but not used [-Wunused-but-set-variable]
>
> It is introduced by commit 543831cfc976 ("drm/vmwgfx:
> Break out surface and context management to separate files"),
> but never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: zhengbin <zhengbin13@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> index 29d8794..de0530b 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> @@ -336,7 +336,6 @@ static void vmw_hw_surface_destroy(struct vmw_resource *res)
>  {
>
>  	struct vmw_private *dev_priv = res->dev_priv;
> -	struct vmw_surface *srf;
>  	void *cmd;
>
>  	if (res->func->destroy == vmw_gb_surface_destroy) {
> @@ -360,7 +359,6 @@ static void vmw_hw_surface_destroy(struct vmw_resource *res)
>  		 */
>
>  		mutex_lock(&dev_priv->cmdbuf_mutex);
> -		srf = vmw_res_to_srf(res);
>  		dev_priv->used_memory_size -= res->backup_size;
>  		mutex_unlock(&dev_priv->cmdbuf_mutex);
>  	}
> --
> 2.7.4
>
>
> .
>

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux