> > Hmm. Pretty much a dummy encoder implementation. Maybe ast is simple > > enough that the simple pipe helpers can do the trick? > > As Daniel said, simple pipe helpers don't support cursors. I > investigated his comment on a encoder helpers and found that many > drivers (including ast) only create an encoder structure without > additional functionality. > > It's probably worth introducing a default implementation for the > encoder, Either that, or make all the callbacks optional so a encoder without additional functionality needs only a few lines of code. > but I'd like to do that in a separate patch set. Ok? Yep, that totally makes sense, given that it'll probably become a patch series of its own (with driver cleanups included). So, for this patch: Acked-by: Gerd Hoffmann <kraxel@xxxxxxxxxx> cheers, Gerd _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
