Hi Laurent, Dave,
On Wed, Nov 06, 2019 at 12:02:05PM +0200, Laurent Pinchart wrote:
> This time with Jacopo correctly CC'ed.
>
> On Wed, Nov 06, 2019 at 12:00:59PM +0200, Laurent Pinchart wrote:
> > Hi Dave,
> >
> > (CC'ing Jacopo)
> >
> > On Wed, Nov 06, 2019 at 01:40:13PM +1000, Dave Airlie wrote:
> > > On Wed, 6 Nov 2019 at 05:56, Dave Airlie wrote:
> > > > On Wed, 6 Nov 2019 at 05:49, Laurent Pinchart wrote:
> > > > >
> > > > > Hi Dave,
> > > > >
> > > > > Has this pull request fallen through the cracks ?
> > > >
> > > > It fell down a different crack than usual, it made it from patchwork
> > > > onto my hard drive, but then I didn't execute the pull.
> > > >
> > > > I've pulled it down, thanks for reminder.
> > >
> > > Now it failed as I mentioned on irc.
> > >
> > > I think the new kconfig option needs to be a tristate, otherwise
> > > setting it to Y and having rcar-du as M fails to link
> >
> > Sorry about that :-S Both I and the 0-day bot failed to catch it.
> > Jacopo, could you please have a look ? I'm afraid this likely mean a new
> > version of the series, and thus missing the merge window, as we're
> > already at -rc6.
I managed to reproduce it by setting DRM=m.
RCAR_CMM stays indeed =y as it's a bool. Simply setting it to tristate
is enough to have it set to =m when DRM=m.
Could this be changed when applying the series ?
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
index 539d232790d1..e6607b5c8bb3 100644
--- a/drivers/gpu/drm/rcar-du/Kconfig
+++ b/drivers/gpu/drm/rcar-du/Kconfig
@@ -14,7 +14,7 @@ config DRM_RCAR_DU
If M is selected the module will be called rcar-du-drm.
config DRM_RCAR_CMM
- bool "R-Car DU Color Management Module (CMM) Support"
+ tristate "R-Car DU Color Management Module (CMM) Support"
depends on DRM && OF
depends on DRM_RCAR_DU
help
Thanks
j
>
> --
> Regards,
>
> Laurent Pinchart
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
