Hi, Sean: On Tue, 2019-11-05 at 16:10 -0500, Sean Paul wrote: > From: Sean Paul <seanpaul@xxxxxxxxxxxx> > > Now that we support both reflections, we can expose 180 degree rotation > and rely on the simplify routine to convert that into REFLECT_X | > REFLECT_Y > Patch 1 ~ 6 of this series looks good to me. For this one, I think the rotation check in mtk_ovl_layer_check() should be modified. Regards, CK > Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx> > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > index f4c4d3fedc5f..4a55bb6e2213 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > @@ -143,8 +143,8 @@ static unsigned int mtk_ovl_layer_nr(struct mtk_ddp_comp *comp) > > static unsigned int mtk_ovl_supported_rotations(struct mtk_ddp_comp *comp) > { > - return DRM_MODE_ROTATE_0 | DRM_MODE_REFLECT_Y | > - DRM_MODE_REFLECT_X; > + return DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_180 | > + DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y; > } > > static int mtk_ovl_layer_check(struct mtk_ddp_comp *comp, unsigned int idx, _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel