Re: [PATCH 1/9] drm/ast: Remove last traces of struct ast_gem_object

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 28, 2019 at 04:49:20PM +0100, Thomas Zimmermann wrote:
> The ast driver has switched to struct drm_vram_gem_object a while ago.
> This patch removes a function and forward declaration that were forgotten
> before.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

Acked-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>

> ---
>  drivers/gpu/drm/ast/ast_drv.h  |  6 ------
>  drivers/gpu/drm/ast/ast_main.c | 24 ------------------------
>  2 files changed, 30 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h
> index ff161bd622f3..f44150ff5483 100644
> --- a/drivers/gpu/drm/ast/ast_drv.h
> +++ b/drivers/gpu/drm/ast/ast_drv.h
> @@ -137,8 +137,6 @@ struct ast_private {
>  int ast_driver_load(struct drm_device *dev, unsigned long flags);
>  void ast_driver_unload(struct drm_device *dev);
>  
> -struct ast_gem_object;
> -
>  #define AST_IO_AR_PORT_WRITE		(0x40)
>  #define AST_IO_MISC_PORT_WRITE		(0x42)
>  #define AST_IO_VGA_ENABLE_PORT		(0x43)
> @@ -289,10 +287,6 @@ extern void ast_mode_fini(struct drm_device *dev);
>  int ast_mm_init(struct ast_private *ast);
>  void ast_mm_fini(struct ast_private *ast);
>  
> -int ast_gem_create(struct drm_device *dev,
> -		   u32 size, bool iskernel,
> -		   struct drm_gem_object **obj);
> -
>  /* ast post */
>  void ast_enable_vga(struct drm_device *dev);
>  void ast_enable_mmio(struct drm_device *dev);
> diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
> index 21715d6a9b56..3a9b4cb73f2f 100644
> --- a/drivers/gpu/drm/ast/ast_main.c
> +++ b/drivers/gpu/drm/ast/ast_main.c
> @@ -535,27 +535,3 @@ void ast_driver_unload(struct drm_device *dev)
>  	pci_iounmap(dev->pdev, ast->regs);
>  	kfree(ast);
>  }
> -
> -int ast_gem_create(struct drm_device *dev,
> -		   u32 size, bool iskernel,
> -		   struct drm_gem_object **obj)
> -{
> -	struct drm_gem_vram_object *gbo;
> -	int ret;
> -
> -	*obj = NULL;
> -
> -	size = roundup(size, PAGE_SIZE);
> -	if (size == 0)
> -		return -EINVAL;
> -
> -	gbo = drm_gem_vram_create(dev, &dev->vram_mm->bdev, size, 0, false);
> -	if (IS_ERR(gbo)) {
> -		ret = PTR_ERR(gbo);
> -		if (ret != -ERESTARTSYS)
> -			DRM_ERROR("failed to allocate GEM object\n");
> -		return ret;
> -	}
> -	*obj = &gbo->bo.base;
> -	return 0;
> -}
> -- 
> 2.23.0
> 

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux