On Fri, Oct 25, 2019 at 11:48:32PM +0000, John Stultz wrote: > Now that the DMA BUF heaps core code has been queued, I wanted > to send out some of the pending changes that I've been working > on. > > For use with Android and their GKI effort, it is desired that > DMA BUF heaps are able to be loaded as modules. This is required > for migrating vendors off of ION which was also recently changed > to support modules. > > So this patch series simply provides the necessary exported > symbols and allows the system and CMA drivers to be built > as modules. > > Due to the fact that dmabuf's allocated from a heap may > be in use for quite some time, there isn't a way to safely > unload the driver once it has been loaded. Thus these > drivers do no implement module_exit() functions and will > show up in lsmod as "[permanent]" > > Feedback and thoughts on this would be greatly appreciated! Do we actually want this? I figured if we just state that vendors should set up all the right dma-buf heaps in dt, is that not enough? Exporting symbols for no real in-tree users feels fishy. -Daniel > > thanks > -john > > Cc: Laura Abbott <labbott@xxxxxxxxxx> > Cc: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx> > Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx> > Cc: Liam Mark <lmark@xxxxxxxxxxxxxx> > Cc: Pratik Patel <pratikp@xxxxxxxxxxxxxx> > Cc: Brian Starkey <Brian.Starkey@xxxxxxx> > Cc: Andrew F. Davis <afd@xxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Yue Hu <huyue2@xxxxxxxxxx> > Cc: Mike Rapoport <rppt@xxxxxxxxxxxxx> > Cc: Chenbo Feng <fengc@xxxxxxxxxx> > Cc: Alistair Strachan <astrachan@xxxxxxxxxx> > Cc: Sandeep Patil <sspatil@xxxxxxxxxx> > Cc: Hridya Valsaraju <hridya@xxxxxxxxxx> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > John Stultz (1): > dma-buf: heaps: Allow system & cma heaps to be configured as a modules > > Sandeep Patil (1): > mm: cma: Export cma symbols for cma heap as a module > > drivers/dma-buf/dma-heap.c | 2 ++ > drivers/dma-buf/heaps/Kconfig | 4 ++-- > drivers/dma-buf/heaps/heap-helpers.c | 2 ++ > kernel/dma/contiguous.c | 1 + > mm/cma.c | 5 +++++ > 5 files changed, 12 insertions(+), 2 deletions(-) > > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel