On Mon, Oct 28, 2019 at 8:55 PM Yi Wang <wang.yi59@xxxxxxxxxx> wrote: > > We get these warnings when build kernel W=1: > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:35:6: warning: no previous prototype for ‘panfrost_perfcnt_clean_cache_done’ [-Wmissing-prototypes] > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:40:6: warning: no previous prototype for ‘panfrost_perfcnt_sample_done’ [-Wmissing-prototypes] > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:190:5: warning: no previous prototype for ‘panfrost_ioctl_perfcnt_enable’ [-Wmissing-prototypes] > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:218:5: warning: no previous prototype for ‘panfrost_ioctl_perfcnt_dump’ [-Wmissing-prototypes] > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:250:6: warning: no previous prototype for ‘panfrost_perfcnt_close’ [-Wmissing-prototypes] > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:264:5: warning: no previous prototype for ‘panfrost_perfcnt_init’ [-Wmissing-prototypes] > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:320:6: warning: no previous prototype for ‘panfrost_perfcnt_fini’ [-Wmissing-prototypes] > drivers/gpu/drm/panfrost/panfrost_mmu.c:227:6: warning: no previous prototype for ‘panfrost_mmu_flush_range’ [-Wmissing-prototypes] > drivers/gpu/drm/panfrost/panfrost_mmu.c:435:5: warning: no previous prototype for ‘panfrost_mmu_map_fault_addr’ [-Wmissing-prototypes] > > For file panfrost_mmu.c, make functions static to fix this. > For file panfrost_perfcnt.c, include header file can fix this. > > Signed-off-by: Yi Wang <wang.yi59@xxxxxxxxxx> > Reviewed-by: Steven Price <steven.price@xxxxxxx> > --- > > v4: make the parameters aligned. > > v3: using tab size of 8 other than 4. > > v2: align parameter line and modify comment. Thanks to Steve. > --- > drivers/gpu/drm/panfrost/panfrost_mmu.c | 9 +++++---- > drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 1 + > 2 files changed, 6 insertions(+), 4 deletions(-) v4 didn't seem to make it to the list yet (non-subscribers get moderated) and I missed this. I applied v3 and fixed up the alignment. Rob _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
