Re: [PATCH] drm/vboxvideo: Use drm_gem_fb_create_with_dirty instead of drm_gem_fb_create

[Hans de Goede <hdegoede@xxxxxxxxxx>]

Hi,

On 28-10-2019 14:38, Thomas Zimmermann wrote:
> Am 28.10.19 um 14:31 schrieb Hans de Goede:
> > Commit 7d79aa8628fe ("drm/vboxvideo: Replace struct vram_framebuffer
> > with generic implemenation") removed the diy framebuffer code from
> > the vboxvideo driver, resulting in a nice cleanup.
> >
> > But since the vboxvideo driver needs the generic dirty tracking code,
> > it's drm_mode_config_funcs.fb_create should be set to
> > drm_gem_fb_create_with_dirty not drm_gem_fb_create.
> >
> > This commit fixes this, fixing the framebuffer not always updating.
> >
> > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > Fixes: Commit 7d79aa8628fe ("drm/vboxvideo: Replace struct vram_framebuffer with generic implemenation")
> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

Thanks, pushed to drm-misc-next

Regards,

Hans


> > ---
> >   drivers/gpu/drm/vboxvideo/vbox_mode.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/vboxvideo/vbox_mode.c b/drivers/gpu/drm/vboxvideo/vbox_mode.c
> > index d9818a8a32fa..f15ed2272205 100644
> > --- a/drivers/gpu/drm/vboxvideo/vbox_mode.c
> > +++ b/drivers/gpu/drm/vboxvideo/vbox_mode.c
> > @@ -838,7 +838,7 @@ static int vbox_connector_init(struct drm_device *dev,
> >   }
> >   
> >   static const struct drm_mode_config_funcs vbox_mode_funcs = {
> > -	.fb_create = drm_gem_fb_create,
> > +	.fb_create = drm_gem_fb_create_with_dirty,
> >   	.atomic_check = drm_atomic_helper_check,
> >   	.atomic_commit = drm_atomic_helper_commit,
> >   };

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel