On Tue, 29 Oct 2019, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> wrote:
> Quoting Jani Nikula (2019-10-28 12:38:20)
>> Mostly for improved documentation, convert the debug category macros
>> into an enum. Drop unused DRM_UT_NONE. Document previously undocumented
>> categories.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> <SNIP>
>
>> +enum drm_debug_category {
>> + /**
>> + * @DRM_UT_CORE: Used in the generic drm code: drm_ioctl.c, drm_mm.c,
>> + * drm_memory.c, ...
>> + */
>> + DRM_UT_CORE = 0x01,
>
> While here, why not BIT()
Thought about it, but since this is what folks look at when adding the
drm.debug module parameter, it's perhaps easier to combine the hex
values than just the bit positions? *shrug* Could go either way.
BR,
Jani.
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
>
> Regards, Joonas
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
