Hi Thomas, On 11-10-2019 15:48, Thomas Zimmermann wrote:
The vboxvideo driver provides its own implementation for fbdev emulation and framebuffers. Both can be replaced by DRM's generic code. All patches have been tested on VirtualBox 6.0.12. Thomas Zimmermann (3): drm/vboxvideo: Switch to generic fbdev emulation drm/vboxvideo: Switch to drm_atomic_helper_dirty_fb() drm/vboxvideo: Replace struct vram_framebuffer with generic implemenation
Thank you for these nice cleanups, unfortunately there is a small bug in the last patch, you are setting: .fb_create = drm_gem_fb_create, But since in the previous patch you switched to drm_atomic_helper_dirty_fb that should be: .fb_create = drm_gem_fb_create_with_dirty, The missing with_dirty is causing screenupdates under both plymouth and gnome-shell (with llvmpipe) to gone missing. I'll send a patch fixing this. Regards, Hans _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel