On Fri, Oct 25, 2019 at 09:30:03PM +0800, Cheng-Yi Chiang wrote: > There will be multiple boards sharing this machine driver. > Use compatible string to specify the use case. > > "rockchip,rockchip-audio-max98090" for max98090-only. > "rockchip,rockchip-audio-hdmi" for HDMI-only > "rockchip,rockchip-audio-max98090-hdmi" for max98090 plus > > Move these properties to optional because they are not needed for > HDMI-only use case. > "rockchip,audio-codec": The phandle of the MAX98090 audio codec > "rockchip,headset-codec": The phandle of Ext chip for jack detection > > The machine driver change will add support for HDMI codec in > rockchip-max98090. > Add one optional property "rockchip,hdmi-codec" to let user specify HDMI > device node in DTS so machine driver can find hdmi-codec device node for > codec DAI. Why not just use the presence of rockchip,hdmi-codec to enable HDMI or not. Maybe you still add rockchip,rockchip-audio-hdmi for HDMI only. Really, the same should have been done for which codec is used too, but I guess someone wanted 2 machine drivers. > > Signed-off-by: Cheng-Yi Chiang <cychiang@xxxxxxxxxxxx> > --- > .../bindings/sound/rockchip-max98090.txt | 38 +++++++++++++++++-- > 1 file changed, 35 insertions(+), 3 deletions(-) _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
