Hi Steve,
Thanks a lot for your review, and I will send a v2 patch ASAP.
> On 19/10/2019 08:28, Yi Wang wrote:
> > We get these warnings when build kernel W=1:
> > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:35:6: warning: no previous prototype for ‘panfrost_perfcnt_clean_cache_done’ [-Wmissing-prototypes]
> > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:40:6: warning: no previous prototype for ‘panfrost_perfcnt_sample_done’ [-Wmissing-prototypes]
> > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:190:5: warning: no previous prototype for ‘panfrost_ioctl_perfcnt_enable’ [-Wmissing-prototypes]
> > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:218:5: warning: no previous prototype for ‘panfrost_ioctl_perfcnt_dump’ [-Wmissing-prototypes]
> > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:250:6: warning: no previous prototype for ‘panfrost_perfcnt_close’ [-Wmissing-prototypes]
> > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:264:5: warning: no previous prototype for ‘panfrost_perfcnt_init’ [-Wmissing-prototypes]
> > drivers/gpu/drm/panfrost/panfrost_perfcnt.c:320:6: warning: no previous prototype for ‘panfrost_perfcnt_fini’ [-Wmissing-prototypes]
> > drivers/gpu/drm/panfrost/panfrost_mmu.c:227:6: warning: no previous prototype for ‘panfrost_mmu_flush_range’ [-Wmissing-prototypes]
> > drivers/gpu/drm/panfrost/panfrost_mmu.c:435:5: warning: no previous prototype for ‘panfrost_mmu_map_fault_addr’ [-Wmissing-prototypes]
> >
> > For file panfrost_mmu.c, make functions static to fix this.
> > For file panfrost_perfcnt.c, include head file can fix this.
>
> Nit: s/head/header/
>
> >
> > Signed-off-by: Yi Wang <wang.yi59@xxxxxxxxxx>
>
> Looks good, just a few minor style issues (below), with those fixed:
>
> Reviewed-by: Steven Price <steven.price@xxxxxxx>
>
> > ---
> > drivers/gpu/drm/panfrost/panfrost_mmu.c | 5 +++--
> > drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 1 +
> > 2 files changed, 4 insertions(+), 2 deletions(-)
> >
...
> > #include "panfrost_regs.h"
> > +#include "panfrost_perfcnt.h"
>
> Please keep header includes sorted alphabetically.
>
> Thanks,
>
> Steve
>
> >
> > #define COUNTERS_PER_BLOCK 64
> > #define BYTES_PER_COUNTER 4
> >
---
Best wishes
Yi Wang
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
