RE: [PATCH 1/4] drm/edid: Make drm_get_cea_aspect_ratio() static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




>-----Original Message-----
>From: dri-devel <dri-devel-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Ville Syrjala
>Sent: Friday, October 4, 2019 7:49 PM
>To: dri-devel@xxxxxxxxxxxxxxxxxxxxx
>Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Wayne Lin <waynelin@xxxxxxx>
>Subject: [PATCH 1/4] drm/edid: Make drm_get_cea_aspect_ratio() static
>
>From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
>drm_get_cea_aspect_ratio() is not used outside drm_edid.c.
>Make it static.

Change looks good to me.
Reviewed-by: Uma Shankar <uma.shankar@xxxxxxxxx>

>Cc: Wayne Lin <waynelin@xxxxxxx>
>Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>---
> drivers/gpu/drm/drm_edid.c | 10 +---------
> include/drm/drm_edid.h     |  1 -
> 2 files changed, 1 insertion(+), 10 deletions(-)
>
>diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index
>0552175313cb..3df8267adab9 100644
>--- a/drivers/gpu/drm/drm_edid.c
>+++ b/drivers/gpu/drm/drm_edid.c
>@@ -3205,18 +3205,10 @@ static bool drm_valid_cea_vic(u8 vic)
> 	return vic > 0 && vic < ARRAY_SIZE(edid_cea_modes);  }
>
>-/**
>- * drm_get_cea_aspect_ratio - get the picture aspect ratio corresponding to
>- * the input VIC from the CEA mode list
>- * @video_code: ID given to each of the CEA modes
>- *
>- * Returns picture aspect ratio
>- */
>-enum hdmi_picture_aspect drm_get_cea_aspect_ratio(const u8 video_code)
>+static enum hdmi_picture_aspect drm_get_cea_aspect_ratio(const u8
>+video_code)
> {
> 	return edid_cea_modes[video_code].picture_aspect_ratio;
> }
>-EXPORT_SYMBOL(drm_get_cea_aspect_ratio);
>
> /*
>  * Calculate the alternate clock for HDMI modes (those from the HDMI vendor diff --
>git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index
>b9719418c3d2..efce675abf07 100644
>--- a/include/drm/drm_edid.h
>+++ b/include/drm/drm_edid.h
>@@ -481,7 +481,6 @@ int drm_add_edid_modes(struct drm_connector *connector,
>struct edid *edid);  int drm_add_override_edid_modes(struct drm_connector
>*connector);
>
> u8 drm_match_cea_mode(const struct drm_display_mode *to_match); -enum
>hdmi_picture_aspect drm_get_cea_aspect_ratio(const u8 video_code);  bool
>drm_detect_hdmi_monitor(struct edid *edid);  bool
>drm_detect_monitor_audio(struct edid *edid);  enum hdmi_quantization_range
>--
>2.21.0
>
>_______________________________________________
>dri-devel mailing list
>dri-devel@xxxxxxxxxxxxxxxxxxxxx
>https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux