Re: [Lima] [PATCH v4 0/3] drm/lima: simplify driver by using more drm helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 10, 2019 at 7:02 AM Qiang Yu <yuq825@xxxxxxxxx> wrote:
>
> By using shared drm helpers:
> 1. drm_gem_(un)lock_reservations
> 2. drm_gem_shmem_helpers
> we can simplify lima driver a lot and benifit from updates to
> these functions.
>
> Patch series is based on drm-misc-next branch
>
> v2:
> Add drm_gem_objects_lookup_user and use it for driver which
> pass user GEM handles in contious array.
>
> v3:
> improve commit comment.
>
> v4:
> Drop drm_gem_objects_lookup refine patches.
>
> Qiang Yu (3):
>   drm/lima: use drm_gem_shmem_helpers
>   drm/lima: use drm_gem_(un)lock_reservations
>   drm/lima: add __GFP_NOWARN flag to all dma_alloc_wc

LGTM, whole series:

Reviewed-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx>

>  drivers/gpu/drm/lima/Kconfig          |   1 +
>  drivers/gpu/drm/lima/Makefile         |   4 +-
>  drivers/gpu/drm/lima/lima_device.c    |   2 +-
>  drivers/gpu/drm/lima/lima_drv.c       |  22 +--
>  drivers/gpu/drm/lima/lima_gem.c       | 195 ++++++++++----------------
>  drivers/gpu/drm/lima/lima_gem.h       |  32 ++++-
>  drivers/gpu/drm/lima/lima_gem_prime.c |  46 ------
>  drivers/gpu/drm/lima/lima_gem_prime.h |  13 --
>  drivers/gpu/drm/lima/lima_mmu.c       |   1 -
>  drivers/gpu/drm/lima/lima_object.c    | 119 ----------------
>  drivers/gpu/drm/lima/lima_object.h    |  35 -----
>  drivers/gpu/drm/lima/lima_sched.c     |   6 +-
>  drivers/gpu/drm/lima/lima_vm.c        |  87 ++++++------
>  13 files changed, 148 insertions(+), 415 deletions(-)
>  delete mode 100644 drivers/gpu/drm/lima/lima_gem_prime.c
>  delete mode 100644 drivers/gpu/drm/lima/lima_gem_prime.h
>  delete mode 100644 drivers/gpu/drm/lima/lima_object.c
>  delete mode 100644 drivers/gpu/drm/lima/lima_object.h
>
> --
> 2.17.1
>
> _______________________________________________
> lima mailing list
> lima@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/lima
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux