On Fri, Oct 04, 2019 at 10:53:44PM +0100, Colin Ian King wrote: > On 04/10/2019 20:27, Liviu Dudau wrote: > > On Fri, Oct 04, 2019 at 05:21:56PM +0100, Colin King wrote: > >> From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > >> > >> The pointer disable_done is being initialized with a value that > >> is never read and is being re-assigned a little later on. The > >> assignment is redundant and hence can be removed. > > > > Not really true, isn't it? The re-assignment is done under the condition that > > crtc->state->active is true. disable_done will be used regardless after the if > > block, so we can't skip this initialisation. > > > > Not sure why Coverity flags this, but I would NAK this patch. > > I'm patching against the driver from linux-next so I believe this is OK > for that. I believe your statement is true against linux which does not > have commit: > > d6cb013579e743bc7bc5590ca35a1943f2b8f3c8 > Author: Lowry Li (Arm Technology China) <Lowry.Li@xxxxxxx> > Date: Fri Sep 6 07:18:06 2019 +0000 > It really does help reviewing patches when this is mentioned in the commit message. There is some debate about whether this should be mentioned as a Fixes since it doesn't fix a bug. I initialy felt it shouldn't be, but now I think enough people think it should be listed as Fixes that I must be wrong. Either way, it's very useful information. The other thing is that soon get_maintainer.pl will start CC'ing people from the Fixes tag and right now Lowry Li is not CC'd so that's unfortunate. regards, dan carpenter _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
