Hi Adam. On Tue, Sep 17, 2019 at 11:12:11AM -0500, Adam Ford wrote: > Previously, there was an omap panel-dpi driver that would > read generic timings from the device tree and set the display > timing accordingly. This driver was removed so the screen > no longer functions. This patch modifies the panel-simple > file to setup the timings to the same values previously used. > > Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> Patch looks good. Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 5a93c4edf1e4..c86c30f3a8a1 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1900,6 +1900,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { > .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > }; > > +static const struct drm_display_mode logicpd_type_28_mode = { > + .clock = 9000, > + .hdisplay = 480, > + .hsync_start = 480 + 3, > + .hsync_end = 480 + 3 + 42, > + .htotal = 480 + 3 + 42 + 2, > + > + .vdisplay = 272, > + .vsync_start = 272 + 2, > + .vsync_end = 272 + 2 + 11, > + .vtotal = 272 + 2 + 11 + 3, > + .vrefresh = 60, > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, > +}; > + > +static const struct panel_desc logicpd_type_28 = { > + .modes = &logicpd_type_28_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 105, > + .height = 67, > + }, > + .delay = { > + .prepare = 200, > + .enable = 200, > + .unprepare = 200, > + .disable = 200, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | > + DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE, > +}; > + > static const struct panel_desc mitsubishi_aa070mc01 = { > .modes = &mitsubishi_aa070mc01_mode, > .num_modes = 1, > @@ -2948,6 +2982,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "lg,lp129qe", > .data = &lg_lp129qe, > + }, { > + .compatible = "logicpd,type28", > + .data = &logicpd_type_28, > }, { > .compatible = "mitsubishi,aa070mc01-ca1", > .data = &mitsubishi_aa070mc01, > -- > 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel