On Wed, Sep 18, 2019 at 2:49 PM Eric Engestrom <eric@xxxxxxxxxxxx> wrote: > On Tuesday, 2019-09-17 19:15:36 +0000, John Stultz wrote: > > This patch removes the deprecated Android.mk files and replaces > > them with Android.bp files. > > > > This is needed in order to build libdrm/master against recent > > Android releases and AOSP/master, as some of the Treble build > > options required since Android O cannot be expressed in > > Andorid.mk files. > > > > Patch originally by Dan Willemsen with fixes folded in by: > > Jerry Zhang, Eliott Hughes and myself. > > > > With this change, the only patches carried by Android for libdrm > > would be the gerrit OWNERS meta-data file. > > > > Cc: Mauro Rossi <issor.oruam@xxxxxxxxx> > > Cc: Chih-Wei Huang <cwhuang@xxxxxxxxxxxxxxx> > > Cc: Robert Foss <robert.foss@xxxxxxxxxxxxx> > > Cc: Tapani Pälli <tapani.palli@xxxxxxxxx> > > Cc: Chih-Wei Huang <cwhuang@xxxxxxxxxxxxxxx> > > Cc: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > Cc: Sean Paul <seanpaul@xxxxxxxxxxxx> > > Cc: Rob Clark <robdclark@xxxxxxxxxxxx> > > Cc: Eric Anholt <anholt@xxxxxxxxxx> > > Cc: Jiyong Park <jiyong@xxxxxxxxxx> > > Cc: Alistair Strachan <astrachan@xxxxxxxxxx> > > Cc: Dan Willemsen <dwillemsen@xxxxxxxxxx> > > Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx> > > Cc: Vishal Bhoj <vishal.bhoj@xxxxxxxxxx> > > Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx> > > --- > > I know last time this was proposed, there was some concern about > > maintaining support for old AOSP releases - and while we could > > still support both with Android.mk that was a fair concern. > > > > However, now that it is a requirement for newer releases, I'd > > contend that being able to build/test libdrm/master against > > AOSP/master and recent releases is more valuable then soley > > maintaining support for old and unsupported Android releases. > > Acked-by: Eric Engestrom <eric@xxxxxxxxxxxx> > > But to be clear, what's the earliest android version that supports > blueprint? (might be worth adding that to the commit message) I believe it was Android N which was the first to use blueprint. Thanks for the review, I'll add such a note to the commit and resubmit w/o RFC in a few days. thanks -john _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
