Re: [PATCH 0/2] drm/panfrost: Tidy up the devfreq implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/12/19 12:28 PM, Steven Price wrote:
The devfreq implementation in panfrost is unnecessarily open coded. It
also tracks utilisation metrics per slot which isn't very useful. Let's
tidy it up!

This should be picked up along with Mark's change[1] to fix
regulator_get_optional() misuse. This also deletes the code changes from
52282163dfa6 and e21dd290881b which would otherwise need reverting, see
the previous discussion[2].

Both patches look great.

Reviewed-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>

Thanks!

Tomeu

[1] https://lore.kernel.org/lkml/20190904123032.23263-1-broonie@xxxxxxxxxx/
[2] https://lore.kernel.org/lkml/ccd81530-2dbd-3c02-ca0a-1085b00663b5@xxxxxxx/

Steven Price (2):
   drm/panfrost: Use generic code for devfreq
   drm/panfrost: Simplify devfreq utilisation tracking

  drivers/gpu/drm/panfrost/panfrost_devfreq.c | 126 ++++++--------------
  drivers/gpu/drm/panfrost/panfrost_devfreq.h |   3 +-
  drivers/gpu/drm/panfrost/panfrost_device.h  |  14 +--
  drivers/gpu/drm/panfrost/panfrost_job.c     |  14 +--
  4 files changed, 48 insertions(+), 109 deletions(-)

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux