Re: [PATCH v2 2/2] drm/bridge: add it6505 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Sep 03, 2019 at 06:51:54PM +0800, allen wrote:
> From: Allen Chen <allen.chen@xxxxxxxxxx>
> 
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
> 
> Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
> Signed-off-by: Yilun Lin <yllin@xxxxxxxxxx>
> Signed-off-by: Allen Chen <allen.chen@xxxxxxxxxx>

I tried to provide feedback on this patch, but it is far from compiling
against the upstream kernel (or -next), and it has a number of obvious
problems such as missing include files, variable type mismatches, and
set but unused variables. It does compile against v4.19.y, but even there
it generates a number of build warnings.

I would suggest to fix those problems and to make sure that the driver
builds without warnings on top of the mainline kernel before resubmitting.

Thanks,
Guenter
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux