Hi, On 08/09/2019 15:51, Cheng-yi Chiang wrote: > On Fri, Aug 30, 2019 at 10:55 AM Cheng-yi Chiang <cychiang@xxxxxxxxxxxx> wrote: >> >> On Wed, Jul 17, 2019 at 6:28 PM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote: >>> >>> On Wed, Jul 17, 2019 at 4:33 PM Cheng-Yi Chiang <cychiang@xxxxxxxxxxxx> wrote: >>>> >>>> This patch series supports HDMI jack reporting on RK3288, which uses >>>> DRM dw-hdmi driver and hdmi-codec codec driver. >>>> >>>> The previous discussion about reporting jack status using hdmi-notifier >>>> and drm_audio_component is at >>>> >>>> https://lore.kernel.org/patchwork/patch/1083027/ >>>> >>>> The new approach is to use a callback mechanism that is >>>> specific to hdmi-codec. >>>> >>>> Changes from v4 to v5: >>>> - synopsys/Kconfig: Remove the incorrect dependency change in v4. >>>> - rockchip/Kconfig: Add dependency of hdmi-codec when it is really need >>>> for jack support. >>>> >>>> Cheng-Yi Chiang (5): >>>> ASoC: hdmi-codec: Add an op to set callback function for plug event >>>> drm: bridge: dw-hdmi: Report connector status using callback >>>> drm: dw-hdmi-i2s: Use fixed id for codec device >>>> ASoC: rockchip_max98090: Add dai_link for HDMI >>>> ASoC: rockchip_max98090: Add HDMI jack support >>>> >>> LGTM. >>> >>> Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx> >> >> Hi Daniel, >> Do you have further concern on this patch series related to hdmi-codec >> and drm part ? >> We would like to merge this patch series if possible. >> They will be needed in many future chrome projects for HDMI audio jack >> detection. >> Thanks a lot! > > Hi Neil, > I am not sure if this patch series is under your radar. > Would you mind taking a look ? > This patch series has been following great suggestions from various > reviewers, so I hope it is fine now. I'd like some review from ASoC people and other drm bridge reviewers, Jernej, Jonas & Andrzej. Jonas could have some comments on the overall patchset. > > Audio jack reporting for HDMI might not be needed for other OS, but it > is a must on ChromeOS. > We have many previous projects using different local patch sets to > achieve HDMI jack reporting. > I hope that we can achieve a proper way and really get the patches > merged to mainline. > Thanks a lot! > Sure, Don't forget to put Jernej, Jonas, and Jerome Brunet <jbrunet@xxxxxxxxxxxx> who is working on integrating audio on the Amlogic SoCs. Neil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
