| What | Removed | Added |
|---|---|---|
| CC | tele42k3@hotmail.com |
Comment # 2
on bug 111527
from tele42k3@hotmail.com
Thanks for the clear steps to reproduce this issue. I managed to reproduce this on my RX 480 and it bisected to: commit 11a3679e3aba3524cf987f1f808d92c25f16e080 Author: Michel Dänzer <michel.daenzer@amd.com> Date: Fri Jun 28 18:35:56 2019 +0200 winsys/amdgpu: Make KMS handles valid for original DRM file descriptor Getting a DMA-buf fd and converting that to a handle using our duplicate of that file descriptor (getting at which requires passing a radeon_winsys pointer to the buffer_get_handle hook) makes sure of this, since duplicated file descriptors reference the same file description and therefore the same GEM handle namespace. This is necessary because libdrm_amdgpu may use a different DRM file descriptor with a separate handle namespace internally, e.g. because it always reuses any existing amdgpu_device_handle for the same device. amdgpu_bo_export returns a handle which is valid for that internal file descriptor. Bugzilla: https://bugs.freedesktop.org/110903 Reviewed-by: Marek Olšák <marek.olsak@amd.com> Tested-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> While testing I saw a .8 to 1 MB/s slow leak which appeared immediately on opening OBS with the test scene. It felt like it consistently hit some obscured value like 64MB before the major memory leak started, which helped bisect the issue. I reverted the commit on top of f8887909c6683986990474b61afd6d4335a69e41 with good results.
You are receiving this mail because:
- You are the assignee for the bug.
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
