Re: [PATCH v3 3/3] drm/vram: Implement lazy unmapping for GEM VRAM buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +void drm_gem_vram_bo_driver_move_notify(struct ttm_buffer_object *bo,
> +					bool evict,
> +					struct ttm_mem_reg *new_mem)
> +{
[ ... ]
> +	if (!kmap->virtual)
> +		return;
> +	ttm_bo_kunmap(kmap);
> +	kmap->virtual = NULL;
> +}

I think ttm_buffer_object_destroy() needs "if (kmap->virtual)
ttm_bo_kunmap()" too, due to the lazy unmap you can land there
with an active mapping.

cheers,
  Gerd

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux