Re: [PATCH] drm: panel-lvds: Potential Oops in probe error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 04, 2019 at 02:50:57PM +0300, Laurent Pinchart wrote:
> >  error:
> > -	put_device(&lvds->backlight->dev);
> > +	if (lvds->backlight)
> > +		put_device(&lvds->backlight->dev);
> 
> How about simply
> 
> -	put_device(&lvds->backlight->dev);
> +	backlight_put(lvds->backlight);

Yeah.  That's cleaner.  I will resend.

regards,
dan carpenter

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux