Hi Tomi, On Tue, Aug 27, 2019 at 12:32:46PM +0300, Tomi Valkeinen wrote: > On 27/08/2019 12:29, Laurent Pinchart wrote: > > On Tue, Aug 27, 2019 at 10:34:59AM +0300, Tomi Valkeinen wrote: > >> On 26/08/2019 16:51, Laurent Pinchart wrote: > >>> On Mon, Aug 26, 2019 at 03:15:23PM +0300, Tomi Valkeinen wrote: > >>>> On 20/08/2019 04:16, Laurent Pinchart wrote: > >>>> > >>>>> The patches can be found at > >>>>> > >>>>> git://linuxtv.org/pinchartl/media.git omapdrm/bridge/devel > >>>> > >>>> I took your branch, booted AM5 EVM (I see you had the hack dts patch in your branch), and: > >>>> > >>>> insmod nfs/work/linux/drivers/media/cec/cec.ko > >>>> insmod nfs/work/linux/drivers/video/fbdev/core/cfbcopyarea.ko > >>>> insmod nfs/work/linux/drivers/video/fbdev/core/cfbimgblt.ko > >>>> insmod nfs/work/linux/drivers/video/fbdev/core/cfbfillrect.ko > >>>> insmod nfs/work/linux/drivers/gpu/drm/drm_panel_orientation_quirks.ko > >>>> insmod nfs/work/linux/drivers/gpu/drm/drm.ko > >>>> insmod nfs/work/linux/drivers/gpu/drm/drm_kms_helper.ko > >>>> insmod nfs/work/linux/drivers/gpu/drm/bridge/ti-tfp410.ko > >>>> insmod nfs/work/linux/drivers/gpu/drm/bridge/sii902x.ko > >>>> insmod nfs/work/linux/drivers/gpu/drm/bridge/tc358767.ko > >>>> insmod nfs/work/linux/drivers/gpu/drm/panel/panel-simple.ko > >>>> [ 25.487002] panel-simple display: display supply power not found, using dummy regulator > >>>> [ 25.495241] ------------[ cut here ]------------ > >>>> [ 25.499900] WARNING: CPU: 0 PID: 303 at drivers/gpu/drm/panel/panel-simple.c:378 panel_simple_probe+0x34c/0x3b4 [panel_simple] > >>> > >>> How am I expected to sneak patches in if you test them ? :-) > >>> > >>> This has been introduced by a recent rebase, and I've only tested the > >>> series on the pandaboard since then. It looks like the problem comes > >>> from > >>> > >>> commit b8a2948fa2b3a5a6da67fd57aa01c7318d795125 > >>> Author: Sean Paul <seanpaul@xxxxxxxxxxxx> > >>> Date: Thu Jul 11 13:34:53 2019 -0700 > >>> > >>> drm/panel: simple: Add ability to override typical timing > >>> > >>> which breaks our out-of-tree DT. As a short term fix I can simply drop > >>> the panel timings from DT, but I think this issue can affect more > >> > >> So just removing the timings from the panel's node should be enough? > >> Still crashing for me, although the panel warning goes away. > > > > My bad, you also need the following patch that I will include in v3. > > Thanks, but I guess I need something more: > > drivers/gpu/drm/panel/panel-simple.c:2384:3: error: ‘const struct > panel_desc’ has no member named ‘connector_type’ > .connector_type = DRM_MODE_CONNECTOR_DPI, Yes, you also need to apply this on top of v3 which I haven't posted yet :-) You can just fetch my omapdrm/bridge/devel branch, I've pushed the latest version there. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
