Re: [PATCH 13/60] drm/bridge: tfp410: Don't include drmP.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tomi,

On Tue, Aug 27, 2019 at 09:38:18AM +0300, Tomi Valkeinen wrote:
> On 07/07/2019 21:18, Laurent Pinchart wrote:
> > The drmP.h header is deprecated, replace it with the headers
> > specifically needed by the tfp410 driver. While at it, replace the DRM
> > print macros with dev_info() and dev_err() instead of including
> > drm_print.h
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/bridge/ti-tfp410.c | 6 ++++--
> >   1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
> > index 8d4690e436c3..a1cad777b057 100644
> > --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> > @@ -18,6 +18,7 @@
> >   #include <linux/platform_device.h>
> >   
> >   #include <drm/drm_atomic_helper.h>
> > +#include <drm/drm_bridge.h>
> >   #include <drm/drm_crtc.h>
> >   #include <drm/drm_print.h>
> >   #include <drm/drm_probe_helper.h>
> 
> You're not actually removing drmP.h. So is the drm_bridge.h needed?

A previous version of the patch did, and I didn't notice someone beat me
to it :-) drm_bridge.h is needed but is included through drm_crtc.h.
Note that Boris has submitted "[PATCH v2 01/21] drm: Stop including
drm_bridge.h from drm_crtc.h" which will change this, and include
drm_bridge.h explicitly in this driver, so I'll drop this patch.

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux