Hi Tomi,
On Tue, Aug 27, 2019 at 09:16:42AM +0300, Tomi Valkeinen wrote:
> On 07/07/2019 21:18, Laurent Pinchart wrote:
> > The TI OP362 is an analog video amplifier controlled through a GPIO. Add
> > support for it to the simple-bridge driver.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/bridge/simple-bridge.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
> > index a7edf3c39627..7495b9bef865 100644
> > --- a/drivers/gpu/drm/bridge/simple-bridge.c
> > +++ b/drivers/gpu/drm/bridge/simple-bridge.c
> > @@ -296,6 +296,11 @@ static const struct of_device_id simple_bridge_match[] = {
> > .timings = &default_bridge_timings,
> > .type = DRM_MODE_CONNECTOR_VGA,
> > },
> > + }, {
> > + .compatible = "ti,opa362",
> > + .data = &(const struct simple_bridge_info) {
> > + .type = DRM_MODE_CONNECTOR_Composite,
> > + },
>
> I have to say I'm pretty clueless about the analog TV, but OMAP DSS
> supports also s-video outputs. But I don't know if OPA362 can be used
> with s-video, or does it dictate composite.
The OPA362 has a single amplifier, so it can't handle S-Video by itself.
Using two instances of the chip may work for such a use case (I haven't
checked in details), but that would require support for non-linear
chains of bridges, which isn't supported today. Let's revisit this topic
when needed (hopefully never :-)).
> In any case,
>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
