Re: [PATCH v2 1/4] drm/panel: Add missing drm_panel_init() in panel drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 23, 2019 at 10:32:42PM +0300, Laurent Pinchart wrote:
> Panels must be initialised with drm_panel_init(). Add the missing
> function call in the panel-raspberrypi-touchscreen.c and
> panel-sitronix-st7789v.c drivers.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Thanks, good to have this done in the right way.

This does not solve any know bugs visible to users. At least there are
no reports I know off. So for now only applied to drm-misc-next.

	Sam

> ---
>  drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 +
>  drivers/gpu/drm/panel/panel-sitronix-st7789v.c        | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> index b5b14aa059ea..2aa89eaecf6f 100644
> --- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> +++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
> @@ -426,6 +426,7 @@ static int rpi_touchscreen_probe(struct i2c_client *i2c,
>  		return PTR_ERR(ts->dsi);
>  	}
>  
> +	drm_panel_init(&ts->base);
>  	ts->base.dev = dev;
>  	ts->base.funcs = &rpi_touchscreen_funcs;
>  
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> index 5e3e92ea9ea6..3b2612ae931e 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> @@ -381,6 +381,7 @@ static int st7789v_probe(struct spi_device *spi)
>  	spi_set_drvdata(spi, ctx);
>  	ctx->spi = spi;
>  
> +	drm_panel_init(&ctx->panel);
>  	ctx->panel.dev = &spi->dev;
>  	ctx->panel.funcs = &st7789v_drm_funcs;
>  
> -- 
> Regards,
> 
> Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux