Comment # 2
on bug 111432
from Mike Lothian
I've bisected this to: 9adc8050bf3ca3e49c65e13259a4c310640542f1 is the first bad commit commit 9adc8050bf3ca3e49c65e13259a4c310640542f1 Author: Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com> Date: Fri Jul 12 15:06:06 2019 -0400 drm/amd/display: make firmware info only load once during dc_bios create Currently every time DC wants to access firmware info we make a call into VBIOS. This makes no sense as there is nothing that can change runtime inside fw info and can cause issues when calling unstable bios during bringup. This change eliminate this behavior by only calling bios once for fw info and keeping it stored as part of dc_bios. Signed-off-by: Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com> Reviewed-by: Chris Park <Chris.Park@amd.com> Acked-by: Leo Li <sunpeng.li@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 3 +- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 3 +- .../amd/display/dc/clk_mgr/dce100/dce_clk_mgr.c | 17 ++++-------- .../drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr.c | 6 ++-- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 7 ++--- drivers/gpu/drm/amd/display/dc/dc_bios_types.h | 5 ++-- .../gpu/drm/amd/display/dc/dce/dce_clock_source.c | 32 ++++++++-------------- drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c | 13 +-------- .../drm/amd/display/dc/dce100/dce100_resource.c | 4 +-- .../drm/amd/display/dc/dce110/dce110_resource.c | 4 +-- .../gpu/drm/amd/display/dc/dce80/dce80_resource.c | 12 ++------ drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 9 +++--- 12 files changed, 36 insertions(+), 79 deletions(-)
You are receiving this mail because:
- You are the assignee for the bug.
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
