In psb_driver_load(), if gma_backlight_init() fails, no cleanup is executed, leading to memory/resource leaks. To fix this issue, go to the 'out_err' label to perform the cleanup work. Signed-off-by: Wenwen Wang <wenwen@xxxxxxxxxx> --- drivers/gpu/drm/gma500/psb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c index 7005f8f..8d264ad 100644 --- a/drivers/gpu/drm/gma500/psb_drv.c +++ b/drivers/gpu/drm/gma500/psb_drv.c @@ -383,7 +383,7 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags) } if (ret) - return ret; + goto out_err; psb_intel_opregion_enable_asle(dev); #if 0 /* Enable runtime pm at last */ -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel